fix: remove edited trigger from PR metadata sync workflow #1034
Conversation
|
@sheikhlimon is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
bot
added
hacktoberfest-accepted
recode
|
✅ Synchronized metadata from Issue #1015:
|
|
@sheikhlimon So what will be the expected behaviour after this update in the sync feature? |
See the other PR when they are edited, like most of them check the box after creating the PR... which makes the metadata basically being created like the amount of times it's being edited, that's sort of unnecessary Edit: I made the change in the PR body, which recreated the metadata below. However, if that's what's expected, that's fine. It's mainly for re-adding Issue No., but people rarely do that. |
|
✅ Synchronized metadata from Issue #1015:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 participants
Description
The PR metadata sync workflow was running on every PR edit, including when users check/uncheck checkboxes in the PR description. This caused:
Fixes #1015
This is a follow-up to which was previously closed with a partial fix. The original fix attempted to detect checkbox-only changes, but the root cause is that the
editedtrigger itself is unnecessary for this workflow.Solution
Removed the
editedevent trigger from the workflow. The workflow now only runs on:opened- When PR is first createdsynchronize- When new commits are pushedreopened- When PR is reopenedI make a change and metadata gets created again